This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Fix "!event" deprecation #1046
Merged
Fix "!event" deprecation #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierstoval
approved these changes
Feb 22, 2017
|
I would use single quotes. Single-quoted YAML scalars are simpler, because there are no special chars inside them (except the single quote itself) |
dunglas
force-pushed
the
deprecations
branch
from
02005b4 to
4f6fccf
Compare
|
@stof done (I've also replaced all existing double quotes by single quotes for the sake of consistency). |
xabbuh
approved these changes
Feb 23, 2017
|
Shouldn't this be done in 2.7 instead? |
|
Why not, but the deprecation is triggered only since 3.3. |
|
Replacing existing quotes should indeed be done in 2.7, to make merging branches easier |
dunglas
force-pushed
the
deprecations
branch
from
4f6fccf to
68a714d
Compare
dunglas
force-pushed
the
deprecations
branch
from
68a714d to
f63ce95
Compare
|
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Feb 24, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Fix "!event" deprecation Commits ------- f63ce95 Uniformize config files and fix deprecations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.